Bump axios from 0.21.1 to 1.8.2 #574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dependabot
bot
added
dependencies
4 tasks
Contributor
Author
|
A newer version of axios exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps [axios](https://github.com/axios/axios) from 0.21.1 to 1.8.2. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v1.x/CHANGELOG.md) - [Commits](axios/axios@v0.21.1...v1.8.2) --- updated-dependencies: - dependency-name: axios dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
This had to do with the different error handling typing introduced in TS 4.0.0 and also with typings for Axios' `AxiosRequestConfig.responseEncoding`, which now also can be a string.
I had to rework a default for a header object from null to {} since it wouldn't be accepted as a AxiosRequestConfig in the new typings from the lib
Axios reworked its typings for headers, which made them incompatible with IOResponse's definition for headers. I used a old workaround to get through this: (T as any)
I had to cast many things here to any in order to avoid risking to change the API we provide to outside the library
In this case, I just clause-guarded the error handling for an instance of AxiosError since the doing the operations that happen after it wouldn't make sense otherwise.
Here, I also clause-guarded the error handling for an AxiosError instance
Once again, I use any-casting to maintain compatibility between AxiosRequestConfig and IORequestConfig
Cast to any to avoid problems between AxiosRequestConfig and IORequestConfig
Once again, only make error handling if we're actually dealing with an AxiosError
Only handle errors which are instances of ApolloError. This particular error handler expects errors will come as extensions of ApolloError, otherwise the operations within the error handler wouldn't make any sense.
Only make operations with status codes if the error is an AxiosError
InternalAxiosRequestConfig is now the actual type being used in AxiosResponse. So our TraceableAxiosRequestConfig should implement that instead of what it was implementing before.
arturpimentel
force-pushed
the
dependabot/npm_and_yarn/axios-1.8.2
branch
from
3d2e677 to
f000934
Compare
juliobguedes
left a comment
juliobguedes
left a comment
There was a problem hiding this comment.
Some initial comments and clarifications
src/HttpClient/middlewares/request/setupAxios/interceptors/tracing/index.ts
Outdated
Show resolved
Hide resolved
src/HttpClient/middlewares/request/setupAxios/interceptors/tracing/index.ts
Outdated
Show resolved
Hide resolved
src/HttpClient/middlewares/request/setupAxios/interceptors/tracing/index.ts
Outdated
Show resolved
Hide resolved
arturpimentel
force-pushed
the
dependabot/npm_and_yarn/axios-1.8.2
branch
from
04a127f to
cda0950
Compare
filafb
reviewed
May 23, 2025
Contributor
filafb
left a comment
filafb
left a comment
There was a problem hiding this comment.
Thanks for keeping the commit tree organized, atomic and well commented. It makes it so easy to review looking at commit by commit, instead of looking at a huge diff.
I found something that might cause a undesired behavior, when handling error, but I am not 100% sure. Let me know what you think.
daniyelnnr
approved these changes
May 23, 2025
src/HttpClient/middlewares/request/setupAxios/interceptors/tracing/index.ts
Show resolved
Hide resolved
arturpimentel
force-pushed
the
dependabot/npm_and_yarn/axios-1.8.2
branch
from
f7f1da3 to
f1d45d9
Compare
juliobguedes
approved these changes
May 29, 2025
filafb
approved these changes
May 29, 2025
After `Create compatibility with TS 3.9.7` (187b096), this isn't needed anymore.
arturpimentel
force-pushed
the
dependabot/npm_and_yarn/axios-1.8.2
branch
from
f1d45d9 to
b653b57
Compare
arturpimentel
force-pushed
the
dependabot/npm_and_yarn/axios-1.8.2
branch
from
9559d80 to
a28ba22
Compare
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps axios from 0.21.1 to 1.8.2.
Release notes
Sourced from axios's releases.
... (truncated)
Changelog
Sourced from axios's changelog.
... (truncated)
Commits
a9f7689chore(release): v1.8.2 (#6812)fb8eec2fix(http-adapter): add allowAbsoluteUrls to path building (#6810)9812045chore(sponsor): update sponsor block (#6804)72acf75chore(sponsor): update sponsor block (#6794)2e64afdchore(release): v1.8.1 (#6800)36a5a62fix(utils): movegenerateStringto platform utils to avoid importing crypto...cceb7b1chore(release): v1.8.0 (#6795)23a25affix(utils): replace getRandomValues with crypto module (#6788)32c7bccfeat: Add config for ignoring absolute URLs (#5902) (#6192)4a3e26cchore(config): adjust rollup config to preserve license header to minified Ja...Maintainer changes
This version was pushed to npm by jasonsaayman, a new releaser for axios since your current version.
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.